Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional param fetching #46

Merged
merged 2 commits into from
Dec 30, 2022
Merged

optional param fetching #46

merged 2 commits into from
Dec 30, 2022

Conversation

Benbentwo
Copy link
Member

what

  • Passing arn as variable removes need to fetch from SSM.

why

  • This allows the module to be used when the keys are in a different region

@Benbentwo Benbentwo requested review from a team as code owners December 30, 2022 19:19
dudymas
dudymas approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@Benbentwo
Copy link
Member Author

/test all

@Benbentwo Benbentwo enabled auto-merge (squash) December 30, 2022 19:50
@Benbentwo Benbentwo merged commit 14fd978 into master Dec 30, 2022
@Benbentwo Benbentwo deleted the optional_param_fetching branch December 30, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudymas dudymas dudymas approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Benbentwo @dudymas @cloudpossebot