Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context.tf #43

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Update context.tf #43

merged 2 commits into from
Dec 10, 2021

Conversation

milldr
Copy link
Member

@milldr milldr commented Dec 10, 2021

what

  • Updated context.tf within both submodules cis-1-2-rules and conformance-pack

why

  • cis-1-2-rules is required for downstream component, compliance
  • updating conformance-pack at the same time as a chore

@milldr milldr requested review from a team as code owners December 10, 2021 06:19
@milldr
Copy link
Member Author

milldr commented Dec 10, 2021

/test all

@korenyoni
Copy link
Member

You're better off running make github/init which updates not only context.tf but also GHA related files.

@korenyoni
Copy link
Member

See for example cloudposse/terraform-aws-ses#48

@korenyoni korenyoni added the patch A minor, backward compatible change label Dec 10, 2021
korenyoni
korenyoni requested changes Dec 10, 2021
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make github/init

@korenyoni
Copy link
Member

Ah didn't know you ran make github/init in #42

Weird that it didn't update the subdirectories. I swear i've seen it work before. Anyways, I'll approve this and look into that behaviour later.

korenyoni
korenyoni approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@milldr milldr merged commit b1876e3 into master Dec 10, 2021
@mergify mergify bot deleted the update-context branch December 10, 2021 07:05
@korenyoni
Copy link
Member

For posterity, the reason why I thought make github/init will replace context.tf in all subdirectories was because it does so manually for examples/complete: https://github.com/cloudposse/build-harness/blob/0d3643df6e2d49b1f5cd8606ec35f6ddd9750073/modules/github/Makefile.init#L33-L35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 was automatically assigned from cloudposse/contributors

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milldr @korenyoni