Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support type key for CodeBuild environment variables #88

Merged
merged 4 commits into from
Apr 22, 2021
Merged

support type key for CodeBuild environment variables #88

merged 4 commits into from
Apr 22, 2021

Conversation

joe-niland
Copy link
Member

@joe-niland joe-niland commented Apr 20, 2021 •
edited
Loading

what

  • [BREAKING CHANGE] modify environment_variables variable to support the 'type' key
  • Unless we change the type of the environment_variables variable to any and default 'type' to 'PLAINTEXT' this will be a breaking change, but a fairly easy one to deal with

why

  • Adding the 'type' key allows sourcing env vars from SSM Parameter Store and Secrets Manager

references

@joe-niland joe-niland marked this pull request as ready for review April 22, 2021 02:43
@joe-niland joe-niland requested review from a team as code owners April 22, 2021 02:43
@joe-niland joe-niland requested review from dotCipher and woz5999 and removed request for a team April 22, 2021 02:43
@joe-niland
Copy link
Member Author

/test all

Gowiem
Gowiem approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use CodeBuild, but I trust you so :shipit: 😅

@Gowiem Gowiem merged commit f2c178b into cloudposse:master Apr 22, 2021
@joe-niland joe-niland deleted the support-env-var-types branch April 22, 2021 23:01
@joe-niland joe-niland mentioned this pull request Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variables from SSM
3 participants
@joe-niland @Gowiem @cloudpossebot