Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for website bucket deployment #94

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fixes for website bucket deployment #94

merged 1 commit into from
Apr 22, 2021

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Apr 21, 2021 •
edited
Loading

what

  • fixes and completes the functionality for deploying to a website bucket
  • fixes the Auto Format PR check

why

  • few things were missing when expanding the produced artifacts into a website bucket - the ability to set object ACL (other than the default public-read canned ACL) and fixing the IAM role permissions

references

@mihaiplesa mihaiplesa requested review from a team as code owners April 21, 2021 22:54
@mihaiplesa mihaiplesa requested review from RothAndrew and SweetOps and removed request for a team April 21, 2021 22:54
@mihaiplesa mihaiplesa force-pushed the mplesa-s3-website-fixes branch 3 times, most recently from 390cb9e to ec1635b Compare April 21, 2021 23:57
@Gowiem
Copy link
Member

Gowiem commented Apr 22, 2021

/test all

Gowiem
Gowiem reviewed Apr 22, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@mihaiplesa mihaiplesa force-pushed the mplesa-s3-website-fixes branch 3 times, most recently from 5cb11a7 to 34f5be4 Compare April 22, 2021 21:03
@mihaiplesa mihaiplesa force-pushed the mplesa-s3-website-fixes branch from 34f5be4 to fa30e39 Compare April 22, 2021 21:07
@mihaiplesa mihaiplesa requested review from Gowiem and removed request for a team April 22, 2021 21:10
@Gowiem
Copy link
Member

Gowiem commented Apr 22, 2021

/test all

@Gowiem Gowiem merged commit b0d16df into cloudposse:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaiplesa @Gowiem