Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds feature: GitHub Webhooks #89

Merged
merged 14 commits into from
Mar 1, 2021
Merged

Conversation

lezavala
Copy link
Contributor

what

  • Adds GitHub Webhooks as in cloudposse/ecs-codepipeline/aws

why

  • Webhooks seems to be less noisy than polling and likely the preferred method.

references

@lezavala lezavala requested review from a team as code owners February 22, 2021 21:48
@lezavala
Copy link
Contributor Author

/rebuild-readme

@lezavala lezavala requested a review from a team as a code owner February 22, 2021 22:29
@lezavala lezavala requested review from adamcrews and joe-niland and removed request for a team February 22, 2021 22:29
@mergify
Copy link

mergify bot commented Feb 26, 2021

This pull request is now in conflict. Could you fix it @lezavala? 🙏

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
lezavala and others added 2 commits March 1, 2021 09:56
Co-authored-by: Vladimir <vladimir.fess@gmail.com>
Co-authored-by: Vladimir <vladimir.fess@gmail.com>
@mergify mergify bot dismissed SweetOps’s stale review March 1, 2021 17:57

This Pull Request has been updated, so we're dismissing all reviews.

lezavala and others added 6 commits March 1, 2021 09:57
Co-authored-by: Vladimir <vladimir.fess@gmail.com>
Co-authored-by: Vladimir <vladimir.fess@gmail.com>
Co-authored-by: Vladimir <vladimir.fess@gmail.com>
@lezavala lezavala requested review from SweetOps and removed request for a team March 1, 2021 18:34
@SweetOps
Copy link

SweetOps commented Mar 1, 2021

/test all

@SweetOps SweetOps merged commit 176ff1f into cloudposse:master Mar 1, 2021
@lezavala lezavala deleted the addWebHooksSupport branch March 1, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants