fix: add support for multiple notifications in budgets #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halilkaya thank you for the taking the time to place this PR, I'm looking deeper into this now. |
|
/test all |
aknysh
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR adds support for multiple notifications in budget as well as a single object of notification.
why
Because we already have a dynamic block that loops notifications. Additionally, aws_budgets_budget resource supports multiple
notificationblock. However currently, it only supports a single object of notification and converts it to single element list in the dynamic block. With this change, it will also be supporting list type to be able to add multiple notifications by keeping backward compatibility.references