This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran Plan in dir: Plan Error Show Output
|
aknysh
previously approved these changes
Feb 13, 2019
This is quite a jump but needed for some recent fixes to do with `users` and `iam`. One of the changes to how IAM user accounts are managed is to have all IAM users centrally managed in `conf/users`. vadzim + aliaksandr are not currently working on CP projects so those users are removed and the other users are in the correct admin groups across all accounts thanks to the `admin_groups` local, where all admin groups across enabled accounts are read from SSM. are added to these groups as they are included in `admin_groups
444714f
to
e9b4916
Compare
maximmi
approved these changes
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This is quite a jump but needed for some recent fixes to do with
users
and
iam
One of the changes to how IAM user accounts are managed is to have all IAM users centrally managed in
conf/users
.vadzim + aliaksandr are not currently working on CP projects so those
users are removed and the other users are in the correct admin groups
across all accounts thanks to the
admin_groups
local [1], where all admingroups across enabled accounts are read from SSM.
[1] https://github.com/cloudposse/root.cloudposse.co/blob/master/conf/users/aknysh.tf#L5