fix isUnavailable

Signed-off-by: Vacant2333 <vacant2333@gmail.com>
cloudpilot-ai · Dec 30, 2024 · b54522b · b54522b
1 parent 9fb2451
commit b54522b
Show file tree

Hide file tree

Showing 4 changed files with 5,898 additions and 635 deletions.
diff --git a/pkg/cache/unavailableofferings.go b/pkg/cache/unavailableofferings.go
@@ -22,11 +22,6 @@ import (
 
 	"github.com/patrickmn/go-cache"
 	"knative.dev/pkg/logging"
-	karpv1 "sigs.k8s.io/karpenter/pkg/apis/v1"
-)
-
-var (
-	spotKey = key("", "", karpv1.CapacityTypeSpot)
 )
 
 // UnavailableOfferings stores any offerings that return ICE (insufficient capacity errors) when
@@ -56,11 +51,6 @@ func NewUnavailableOfferings() *UnavailableOfferings {
 
 // IsUnavailable returns true if the offering appears in the cache
 func (u *UnavailableOfferings) IsUnavailable(instanceType, zone, capacityType string) bool {
-	if capacityType == karpv1.CapacityTypeSpot {
-		if _, found := u.cache.Get(spotKey); found {
-			return true
-		}
-	}
 	_, found := u.cache.Get(key(instanceType, zone, capacityType))
 	return found
 }

diff --git a/pkg/controllers/interruption/controller.go b/pkg/controllers/interruption/controller.go
@@ -85,7 +85,7 @@ func (c *Controller) Reconcile(ctx context.Context, node *corev1.Node) (reconcil
 	return reconcile.Result{}, nil
 }
 
-func (c *Controller) Register(ctx context.Context, m manager.Manager) error {
+func (c *Controller) Register(_ context.Context, m manager.Manager) error {
 	return controllerruntime.NewControllerManagedBy(m).
 		Named("interruption").
 		For(&corev1.Node{}).

diff --git a/pkg/controllers/nodeclaim/garbagecollection/controller.go b/pkg/controllers/nodeclaim/garbagecollection/controller.go
@@ -39,9 +39,10 @@ import (
 )
 
 type Controller struct {
-	kubeClient      client.Client
-	cloudProvider   cloudprovider.CloudProvider
-	successfulCount uint64 // keeps track of successful reconciles for more aggressive requeueing near the start of the controller
+	kubeClient    client.Client
+	cloudProvider cloudprovider.CloudProvider
+	// Keeps track of successful reconciles for more aggressive requeueing near the start of the controller.
+	successfulCount uint64
 }
 
 func NewController(kubeClient client.Client, cloudProvider cloudprovider.CloudProvider) *Controller {