Feature/scmm pr handling #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Don't expose methods that return SCM-Mananger specific data, as we might want to abstract a SCM interface that might be implemented by SCM-Manager, GitHub, etc.
schnatterer
reviewed
Jan 25, 2021
schnatterer
reviewed
Jan 25, 2021
| httpCode = httpCode.trim() | ||
| script.echo "Creating pull request yields httpCode: ${httpCode}" | ||
| if (httpCode != "201") { | ||
| script.unstable 'Could not create pull request' |
There was a problem hiding this comment.
Wouldn't it be more versatile to return false here?
This way the caller can decide what to do about it.
We could even think about adding a createOrUpdate() method
There was a problem hiding this comment.
Also, the execution continues after the unstable call!
That is, it causes an exception java.lang.NullPointerException: Cannot invoke method split() on null object because the following is still executed return httpResponse.headers.location.split("/")[-1]
There was a problem hiding this comment.
schnatterer
reviewed
Jan 25, 2021
schnatterer
reviewed
Jan 25, 2021
schnatterer
reviewed
Jan 26, 2021
We have needed this several times in libs and also in Jenkinsfiles. In addition implementing it inside a functional class such as Git or SCMManager, is the opposite of separation of concerns.
schnatterer
reviewed
Jan 27, 2021
"java.lang.NullPointerException: Cannot invoke method split() on null object" cause by ongoing control flow after script.unstable.
schnatterer
force-pushed
the
feature/scmm_pr_handling
branch
from
5016ef9 to
5bf1c43
Compare
Use HttpClient mock and JsonOutput instead of raw curl outputs.
Allows for extension, not just PRs. Also extends test: - also assert URLs, content type and body - removes unit tests for protected method (it's only used internally, is is tested via public API)
Signed-off-by: Marek Markiewka <marek.markiewka@cloudogu.com>
… unstable Signed-off-by: Philipp Markiewka <philipp.markiewka@cloudogu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements pull request handling for the SCM-Manager