Merge pull request #54 from cloudogu/bugfix/location_for_prId

Bugfix/location for pr
cloudogu · Feb 25, 2021 · 01970ee · 01970ee
2 parents f7334c4 + 69e73a4
commit 01970ee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/com/cloudogu/ces/cesbuildlib/SCMManager.groovy b/src/com/cloudogu/ces/cesbuildlib/SCMManager.groovy
@@ -45,7 +45,7 @@ class SCMManager implements Serializable {
         }
 
         // example: "location: https://some/pr/42" - extract id
-        return httpResponse.headers.location.split("/")[-1]
+        return httpResponse.headers.Location.split("/")[-1]
     }
 
     boolean updatePullRequest(String repository, String pullRequestId, String title, String description) {

diff --git a/test/com/cloudogu/ces/cesbuildlib/SCMManagerTest.groovy b/test/com/cloudogu/ces/cesbuildlib/SCMManagerTest.groovy
@@ -98,7 +98,7 @@ class SCMManagerTest {
 
             return [
                 httpCode: '201',
-                headers: [ location: 'https://a/long/url/with/id/id/12' ]
+                headers: [ Location: 'https://a/long/url/with/id/id/12' ]
             ]
         })
 
@@ -110,7 +110,7 @@ class SCMManagerTest {
     void "error on pull request creation makes build unstable"() {
         when(httpMock.post(any(), any(), any())).thenReturn([
             httpCode: '500',
-            headers: [ location: 'https://a/long/url/with/id/id/12' ]
+            headers: [ Location: 'https://a/long/url/with/id/id/12' ]
         ])
 
         def id = scmm.createPullRequest(repo, 'source', 'target', 'title', 'description')
@@ -192,7 +192,7 @@ class SCMManagerTest {
 
             return [
                 httpCode: '201',
-                headers: [ location: 'https://a/long/url/with/id/id/12' ]
+                headers: [ Location: 'https://a/long/url/with/id/id/12' ]
             ]
         })