Ability to use unix socket for connection to nsqd #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iseletsk
reviewed
Dec 26, 2022
conn.go
Outdated
|
|
||
| // create a local copy of the config to set ServerName for this connection | ||
| conf := &tls.Config{} | ||
| if tlsConf != nil { | ||
| conf = tlsConf.Clone() | ||
| } | ||
| conf.ServerName = host | ||
| if c.socketType == "tcp" { |
There was a problem hiding this comment.
You did !unixSocket in another place. Maybe it would be better for consistency to do the same here.
There was a problem hiding this comment.
also, I don't think we will ever get in here (inside upgradeTLS) for unixSocket. How / why would we?
There was a problem hiding this comment.
Keeping backward compatibility with TLS and no need to specify conflicting options explicitly
moredure
approved these changes
Dec 27, 2022
conn.go
Outdated
| @@ -90,8 +93,13 @@ func NewConn(addr string, config *Config, delegate ConnDelegate) *Conn { | |||
| if !config.initialized { | |||
| panic("Config must be created with NewConfig()") | |||
| } | |||
| socketType := "tcp" | |||
There was a problem hiding this comment.
Probably, it's better to organise this part as method func (*Conn) socketType() string instead of procedure isSocket since it won't be called too frequently it should not affect performance, but in general LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example to use reader:
and writer:
with connection to nsqd via unix sockets.