xen: stop using loop device in run.py #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch eliminates use of losetup in run.py when running OSv on Xen. Instead of creating a loop device pointing to qcow2 or raw image, run.py adds an entry to the xl config file pointing directly to the OSv disk image like so: disk=['/home/wkozaczuk/projects/osv/build/last/usr.img,qcow2,hda,rw'] or: disk=['/home/wkozaczuk/projects/osv/build/last/usr.raw,raw,hda,rw'] In addition, we also enhance run.py to support 2nd disk when running OSv on Xen. Finally, when executing run.py with '--dry-run', one can see content of the xl config file which can be useful for troubleshouting or manually running OSv using the xl utility. Examples to run OSv on Xen: ./scripts/run.py -p xen #uses default qcow2 image build/last/usr.img ./scripts/run.py -nv -c 1 -p xen --script vif-bridge -b virbr0 ./scripts/run.py -p xen --second-disk-image ./disk.raw Fixes cloudius-systems#285 Fixes cloudius-systems#344 Signed-off-by: Waldemar Kozaczuk <jwkozaczuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch eliminates the use of
losetupinrun.pywhen running OSv on Xen. Instead of creating a loop device pointing to qcow2 or raw image, run.py adds an entry to the xl config file pointing directly to the OSv disk image like so:disk=['/home/wkozaczuk/projects/osv/build/last/usr.img,qcow2,hda,rw']or:
disk=['/home/wkozaczuk/projects/osv/build/last/usr.raw,raw,hda,rw']In addition, we also enhanced
run.pyto support 2nd disk when running OSv on Xen. Finally, when executing run.py with '--dry-run', one can see the content of the xl config file which can be useful for troubleshooting or manually running OSv using the xl utility.Examples to run OSv on Xen:
Fixes #285
Fixes #344