Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] requestIdleCallback is not supported in Safari #121

Closed
colbyfayock opened this issue Feb 6, 2023 · 1 comment · Fixed by #122
Closed

[Bug] requestIdleCallback is not supported in Safari #121

colbyfayock opened this issue Feb 6, 2023 · 1 comment · Fixed by #122
Labels
released

Comments

@colbyfayock
Copy link
Collaborator

Bug Report

Describe the bug

See: remix-run/indie-stack#124 (comment)

Is this a regression?

Steps To Reproduce the error

Expected behaviour

CodeSandbox or Live Example of Bug

Screenshot or Video Recording

Your environment

  • OS:
  • Node version:
  • Npm version:
  • Browser name and version:

Additional context
@colbyfayock colbyfayock mentioned this issue Feb 6, 2023
Merged
12 tasks
colbyfayock added a commit that referenced this issue Feb 6, 2023
@colbyfayock
fix: Adds requestIdleCallback fallback (#122)
27aac1a 
# Description

requestIdleCallback doesn't have complete browser support, so this adds
a fallback in case it doesnt exist.

https://caniuse.com/requestidlecallback

## Issue Ticket Number

Fixes #121 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> -->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket
for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the
same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Feb 6, 2023
@semantic-release-bot
chore(release): 2.1.1 [skip ci]
c90cdd4 
## [2.1.1](v2.1.0...v2.1.1) (2023-02-06)

### Bug Fixes

* Adds requestIdleCallback fallback ([#122](#122)) ([27aac1a](27aac1a)), closes [#121](#121)
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cham74 added a commit to cham74/next-image-delivery that referenced this issue Dec 23, 2023
@cham74
chore(release): 2.1.1 [skip ci]
61c4c41 
## [2.1.1](cloudinary-community/next-cloudinary@v2.1.0...v2.1.1) (2023-02-06)

### Bug Fixes

* Adds requestIdleCallback fallback ([#122](cloudinary-community/next-cloudinary#122)) ([27aac1a](cloudinary-community/next-cloudinary@27aac1a)), closes [#121](cloudinary-community/next-cloudinary#121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds requestIdleCallback fallback cloudinary-community/next-cloudinary
1 participant
@colbyfayock