Optimize striped table component for dark theme and fix caption color #1242
Conversation
|
|
Hey @spaceninja, I was wondering if you could review this. Paul brought up the issue but he's gone for the day and I'm not sure if I named the variables in the best way. :/ |
There was a problem hiding this comment.
The code is good.
As for the custom property name, I don't think we've settled on a standard yet for colors that change based on the theme.
We're supposed to name things in increasing order of specificity, so color-table-striped is good. We've been using theme as a way to indicate this color responds to the light/dark theme, but it's unclear where they should be in the naming order.
I've used color-theme in the past, but I don't think that's required.
If you're concerned about it, I'd wait to see what @Paul-Hebert thinks in the morning, but I'd also be happy with merging this as-is, since we don't have an agreed-upon standard for naming these color properties yet.
…into feature/button-group-object * 'v-next' of github.com:cloudfour/cloudfour.com-patterns: Fix broken documentation links (#1248) Test Mule -> Pleasantest (#1246) Update dependency postcss-loader to v4.3.0 Update dependency postcss to v8.3.0 Update dependency eslint to v7.27.0 Fix storybook implicit postcss deprecation warning (#1245) Add new card variation prototype (#1241) Add animation to sky nav (#1239) Optimize striped table component for dark theme and fix caption color (#1242) Update dependency rollup-plugin-dts to v3.0.2 (#1236) # Conflicts: # src/components/button/button.stories.mdx
Overview
There was an issue where the striped variation of the table component didn't look right on the dark theme. The caption of the table also remained a dark gray on the dark theme as well. This PR changes the stripes from a light gray to a dark blue and changes the caption color to a lighter gray.
Screenshots
Testing