Fix cargo local with Tomcat 9.0.100 #3313
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kehrlann
commented
Feb 26, 2025
Kehrlann
commented
- Fixes a regression in the dev environment introduced in 4d292c2
- This is similar to a Boot issue here: Tomcat 10.1.36 causes application startup failures due to DirResourceSet.initInternal() changes spring-projects/spring-boot#44342 ; since this is Tomcat-version related issue, and only happens in cargo, we're using the simplest fix. We chose not to invest in this, because when the Boot migration is complete we will be getting rid of Cargo entirely.
- Fixes a dev regression introduced in 4d292c2 - This is similar to a Boot issue here: spring-projects/spring-boot#44342 ; since this is Tomcat-version related issue, and only happens in cargo, we're using the simplest fix. We chose not to invest in this, because when the Boot migration is complete we will be getting rid of Cargo entirely.
duanemay
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.