-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Info Endpoint: optimize OAuth IdPs for JSON Response #3254
Merged
adrianhoelzl-sap
merged 8 commits into
develop
from
login-info-endpoint-optimize-oauth-idps-for-json-response
Feb 14, 2025
Merged
Login Info Endpoint: optimize OAuth IdPs for JSON Response #3254
adrianhoelzl-sap
merged 8 commits into
develop
from
login-info-endpoint-optimize-oauth-idps-for-json-response
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcc24a6
to
e18939e
Compare
e18939e
to
f31a1c6
Compare
strehle
approved these changes
Feb 5, 2025
Should #3251 be closed, with this one? |
strehle
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved already... do you need anything from other approvers ?
btw. can you answer question from @duanemay
duanemay
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(alternative for #3251)
This PR optimizes the login info endpoint so that it does not fetch all OAuth IdPs when a JSON response is requested.
Prior to the optimization, all OAuth IdPs are queried and then used for determining a potential redirect to the corresponding external IdP. However, for JSON responses the redirect is ignored anyway.
The optimization introduces the following changes to the JSON response, which are in our opinion acceptable:
showLoginLinks
is no longer returned if there is also no SAML IdP withshowSamlLink
enabledidpDefinitions
anywaypasscode
prompt is no longer removed if there is no SAML/OIDC IdP withshowSamlLink
/showLinkText
in the IdP definitions listThe first few commits in this PR are refactorings of the endpoint handler, they don't change any behavior. We advise to go through the PR from commit to commit.