Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight list filters & fix cf events list clear filter #4749

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

richard-cox
Copy link
Contributor

- In list header highlight values that effect the list
  - multi filters
  - text filters
  - sort
  - chips
- This includes custom filters that live outside of the list component
  - cf events list
  - helm charts list
- Also fix an issue in the cf events list where the actee filter's `x` button was not visible on click of actee
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 6172a2e into master Nov 5, 2020
@nwmac nwmac deleted the highlight-list-selection branch November 5, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants