Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure are you still there dialog is closed before showing logging out page #4730

Merged
merged 5 commits into from
Nov 3, 2020

Conversation

richard-cox
Copy link
Contributor

  • fixes 'Are you logged in' dialog seen on logging out page #4468
  • Tested by.... src/frontend/packages/core/src/logged-in.service.ts
     this._promptInactiveUser(Date.now() + (1 * 1000 * 10));
     this.closeSessionCheckerPoll();
     // if (aboutToExpire) {
     //   const idleDelta = now - this.lastUserInteraction;
     //   const userIsActive = idleDelta < this.userIdlePeriod;
     //   const pageVisible = new PageVisible(document);
     //   if ((!dashboardState.timeoutSession && pageVisible.isPageVisible()) || userIsActive) {
     //     this.store.dispatch(new VerifySession(false, false));
     //   } else {
     //     this._promptInactiveUser(safeExpire);
     //     this.closeSessionCheckerPoll();
     //   }
     // }
    

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit cd89026 into master Nov 3, 2020
@richard-cox richard-cox deleted the fix-timeout-overlay branch November 3, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Are you logged in' dialog seen on logging out page
2 participants