Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to error/notification process #4053

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Improvements to error/notification process #4053

merged 3 commits into from
Dec 13, 2019

Conversation

richard-cox
Copy link
Contributor

  • Show mini error message, as per create, when updating service instance
  • Handle all 5XX status codes as errors
  • Update messages to reflect varience of error states
  • Show single popover message on error dismiss all button
  • Correct error page selector

@richard-cox
Improvements to error/notification process
56cf03d 
- Show mini error message, as per create, when updating service instance
- Handle all 5XX status codes as errors
- Update messages to reflect varience of error states
- Show single popover message on error dismiss all button
- Correct error page selector
@richard-cox richard-cox self-assigned this Dec 9, 2019
@richard-cox
Treat calls to multiple endpoints as global
4ab831c 
- calls where we generate the endpoint lists (app wall, etc) were handled badly by jetstreamErrorHandler
- this was due to the internal event storing endpoint id as `` instead of one per endpoint
- this happened due to the list of generated endpoints being applied directly to request object in lower function
- treat these as global for the moment
@richard-cox
Merge remote-tracking branch 'origin/master' into error-notification-…
174cd6a 
…improvements
nwmac
nwmac approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 9d1751b into master Dec 13, 2019
@nwmac nwmac deleted the error-notification-improvements branch December 13, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac