Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local auth session timeout #4028

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Fix local auth session timeout #4028

merged 3 commits into from
Dec 3, 2019

Conversation

richard-cox
Copy link
Contributor

  • With local auth enabled, in some cases, the automatic timeout would cause the client to spam the verify request
  • This was caused by the verify request not updating the session expired date
  • Also fixed ang8 upgrade issue where header information was not sent... such as x-cap-request-date (I don't think this was needed for the fix though)
  • blocked on Ensure active dialog times out correctly #4026

@richard-cox
Ensure active dialog times out correctly
71ba470 
- previously.. time out duration was checked every tick of `interval`
  - this slows down when tab is not active, leading to situation when session was inactive but time out counter was still ticking. Clickin 'yes' then lead to log out
- now..
  - tick as before but check timeout via date every time
- also..
  - added some code on the way that wasn't needed, but may be in the future
  - will delete later if not used
@richard-cox
Fix usages of new HttpHeaders()
862ffa7 
- Changes following http to http client update
- Some places have dropped `application/x-www-form-urlencoded`, this is automatically added
- Now `x-cap-request-date` should correctly be sent
@richard-cox
Fix local auth session timeout
7957887 
- The session expiry time was never updated upon successful `verify` requests
- Now this is down at the top level session verify instead of within uaa verify
@richard-cox richard-cox self-assigned this Nov 28, 2019
@nwmac nwmac removed the blocked-pr label Dec 3, 2019
@nwmac nwmac changed the base branch from master to dark-theme December 3, 2019 10:04
@nwmac nwmac changed the base branch from dark-theme to master December 3, 2019 10:04
nwmac
nwmac approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit ee9c4e0 into master Dec 3, 2019
@nwmac nwmac deleted the fix-local-user-timeout branch December 3, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac