Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure both private and shared domains are included in domain lists #3695

Merged
merged 4 commits into from
Jul 16, 2019
Merged

Ensure both private and shared domains are included in domain lists #3695

merged 4 commits into from
Jul 16, 2019

Conversation

richard-cox
Copy link
Contributor

  • Before we were using shared_domains to fetch domains. This fetched all shared domains of the cf and did not include private domains (those that are bound to orgs)
  • In a lot of cases we just needed the domains available to a specific org
  • So the following usages have been updated to use organization/<guid>/domain
    • app routes table
    • app create/bind stepper create form
    • app create/bind stepper bind form
    • deploy app stepper overrides step
  • Note - The create app stepper worked before as it fetched them directly from the org entity
  • fixes create route - owned domains not proposed #3685

@richard-cox
Ensure both private and shared domains are included in create/map dro…
fbc48f3 
…p downs

- Before we were using `shared_domains` to fetch domains. This fetched all shared domains of the cf
- In a lot of cases we just needed the domains available to the org
- So the following usages have been updated to use org/<guid>/domain
  - app routes table
  - app create/bind stepper create form
  - app create/bind stepper bind form
  - deploy app stepper overrides step
- Note - The create app stepper worked before as it fetched them directly from the org entity
@richard-cox richard-cox self-assigned this Jul 8, 2019
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jul 8, 2019 •
edited
Loading

Codecov Report

Merging #3695 into v2-master will decrease coverage by 0.03%.
The diff coverage is 34.09%.

@@             Coverage Diff              @@
##           v2-master   #3695      +/-   ##
============================================
- Coverage      51.43%   51.4%   -0.04%     
============================================
  Files            726     726              
  Lines          20569   20593      +24     
  Branches        3682    3687       +5     
============================================
+ Hits           10579   10585       +6     
- Misses          9990   10008      +18

nwmac
nwmac suggested changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix actions names

src/frontend/packages/store/src/actions/organization.actions.ts Outdated
@@ -20,6 +30,10 @@ export const GET_ORGANIZATION_SPACES = '[Space] Get all org spaces';
export const GET_ORGANIZATION_SPACES_SUCCESS = '[Space] Get all org spaces success';
export const GET_ORGANIZATION_SPACES_FAILED = '[Space] Get all org spaces failed';

export const GET_ORGANIZATION_DOMAINS = '[Space] Get all org spaces';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get all org domains - fix others as well

@nwmac nwmac added the needs attention This PR needs attention label Jul 15, 2019
@richard-cox richard-cox removed needs attention This PR needs attention labels Jul 15, 2019
nwmac
nwmac approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit e87f91e into v2-master Jul 16, 2019
@nwmac nwmac deleted the fix-private-domains branch July 16, 2019 08:01
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge remote-tracking branch 'origin/entity-catalogue-store' into sto…
89cf684 
…re-cf-reducers

* origin/entity-catalogue-store: (196 commits)
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Fix persist of dashboard settings - side nav will now retain out/in state - added additional logging
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  Add logging
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-reducers2
d54956c 
* entity-catalogue-store: (196 commits)
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  Add logging
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-reducers3
7adbcf3 
* entity-catalogue-store: (197 commits)
  Fix imports
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-types
d37cc79 
* entity-catalogue-store: (197 commits)
  Fix imports
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create route - owned domains not proposed
3 participants
@richard-cox @cfdreddbot @nwmac