Add eirini plugin to contain eirini config #3631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- persist data to new db table - update on connect/unregister - return, per endpoint, relations from db
- optionally include shared endpoints in ListEndpointsByUser
- eirini enabled, default namespace - will later on include enpoints to fetch default namespace & store cf enabled/namespace state
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3631 +/- ##
=============================================
+ Coverage 51.68% 51.72% +0.04%
=============================================
Files 723 723
Lines 20381 20375 -6
Branches 3641 3641
=============================================
+ Hits 10533 10539 +6
+ Misses 9848 9836 -12 |
|
Closing in favour of #3809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO - Populate env vars given SCF_VALUES
enabled.eiriniscf.eirini.enabled+scf.eirini.enabled__helpers.tmpto populate new eirini env vars