Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide endpoints page when using SQLite #3463

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Hide endpoints page when using SQLite #3463

merged 2 commits into from
Apr 18, 2019

Conversation

richard-cox
Copy link
Contributor

- user will not be redirected to endpoint page on no registered/connected endpoint
- sidenav endpoint option will not be shown
- navigating directly to endpoint page will redirect to applications
- message shown when no connected/registered endpoints has been updated
  - these should only been shown in unsupported situations (non-cf deployed app with no persistent storage)
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@richard-cox richard-cox changed the base branch from v2-master to 2.0.0-base April 4, 2019 14:35
@richard-cox richard-cox changed the base branch from 2.0.0-base to v2-master April 4, 2019 14:35
@richard-cox richard-cox added needs attention This PR needs attention ready for review and removed blocked-pr labels Apr 4, 2019
@richard-cox richard-cox removed the needs attention This PR needs attention label Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3463 into v2-master will increase coverage by 0.02%.
The diff coverage is 62.85%.

@@             Coverage Diff              @@
##           v2-master   #3463      +/-   ##
============================================
+ Coverage      51.68%   51.7%   +0.02%     
============================================
  Files            704     704              
  Lines          19580   19592      +12     
  Branches        3459    3462       +3     
============================================
+ Hits           10120   10131      +11     
- Misses          9460    9461       +1

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 2b7a660 into v2-master Apr 18, 2019
@nwmac nwmac deleted the hide-endpoints branch April 18, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants