Ensure Service Instance counts are correct #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SI arrays returned within a Space include User Provided Service Instances - This would normally be fine however we show this count next to the service instance quota. The quota however does not take into account - Now we don't rely on inline service instances at all - Additionally we also show the UPSI count (if greater than zero) - Also removed unused component `card-cf-org-usage.component`
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3448 +/- ##
=============================================
+ Coverage 51.44% 51.48% +0.04%
=============================================
Files 697 696 -1
Lines 19418 19439 +21
Branches 3427 3438 +11
=============================================
+ Hits 9989 10008 +19
- Misses 9429 9431 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SI arrays returned within a Space include User Provided Service Instances
This would normally be fine however we show this count next to the service instance quota.
The quota however does not take into account
Now we don't rely on inline service instances at all
Additionally we also show the UPSI count (if greater than zero)
Also removed unused component
card-cf-org-usage.componentFixes User Provided Services: Handle service instance counts #3442