-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add card view to endpoint list #3422
Merged
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f5c95f3
Merge branch 'fix-fav-hypen-cf-guid' into endpoint-list-cards
richard-cox 9439153
WIP
richard-cox b96c9cd
Merge branch 'fix-fav-hypen-cf-guid' into endpoint-list-cards
richard-cox db6fc07
WIP
richard-cox ff9a923
Actions
richard-cox 4dc7876
Add endpoint type icons & custom endpoint details table column/card s…
richard-cox 67dabc4
Fix unit tests
richard-cox df782df
WIP
richard-cox 9896a96
WIP
richard-cox 170b3c5
Fix tests
richard-cox dccb9fc
Tweak cf details
richard-cox 9f9bcea
Fix linting
richard-cox cfa8891
Fix existing getIconButton bug
richard-cox e9cd91d
Missing images
richard-cox 590fa9e
Disable endpoint card routerLink using new directive
richard-cox a9d6fd6
Fix linting, don't show image if no image
richard-cox 828ec17
Another lint fix
richard-cox 86eff1f
Merge remote-tracking branch 'origin/v2-master' into endpoint-list-cards
nwmac d59ac52
Fix lint issues
nwmac 58a8bd9
Fix merge issue
nwmac d6b5250
Fix merge issue
nwmac 0b457fb
Fix issues from review
richard-cox 2083cc8
Fix unit test
richard-cox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
50 changes: 50 additions & 0 deletions
50
src/frontend/packages/core/assets/endpoint-icons/metrics.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
src/frontend/packages/core/src/core/disable-router-link.directive.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { Directive, Input, Optional } from '@angular/core'; | ||
import { RouterLink, RouterLinkWithHref } from '@angular/router'; | ||
|
||
@Directive({ | ||
selector: '[routerLink][appDisableRouterLink]' | ||
}) | ||
export class DisableRouterLinkDirective { | ||
|
||
@Input() appDisableRouterLink: boolean; | ||
|
||
constructor( | ||
// Inject routerLink | ||
@Optional() routerLink: RouterLink, | ||
@Optional() routerLinkWithHref: RouterLinkWithHref | ||
) { | ||
|
||
const link = routerLink || routerLinkWithHref; | ||
|
||
// Save original method | ||
const onClick = link.onClick; | ||
|
||
// Replace method | ||
link.onClick = (...args) => { | ||
if (this.appDisableRouterLink) { | ||
return routerLinkWithHref ? false : true; | ||
} else { | ||
return onClick.apply(link, args); | ||
} | ||
}; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,4 @@ | |
<ng-content *ngTemplateOutlet="value.content"></ng-content> | ||
</div> | ||
</div> | ||
</ng-template> | ||
</ng-template> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent with the extensions folder/package was that it should not import anything else in the Stratos code base - thus it could be a separate package and extensions would only need to import the extensions package - they would not need to import anything else.
Is there a way to loosen the typing on listDetailsComponent and check it at runtime for compatibility?