Add check to make sure DB Schema migrations have completed #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2977 +/- ##
=============================================
- Coverage 71.08% 71.03% -0.05%
=============================================
Files 607 607
Lines 26197 26243 +46
Branches 5931 5935 +4
=============================================
+ Hits 18621 18641 +20
- Misses 7576 7602 +26 |
richard-cox
suggested changes
Sep 12, 2018
src/jetstream/datastore/datastore.go
Outdated
| for { | ||
| dbVersionRepo, _ := goosedbversion.NewPostgresGooseDBVersionRepository(db) | ||
| databaseVersionRec, err := dbVersionRepo.GetCurrentVersion() | ||
| if err == nil && databaseVersionRec.VersionID == targetVersion.Version { |
There was a problem hiding this comment.
If there is an err we'll get stuck in a never ending loop, which given the function isn't so bad... but we should log the err to help debugging.
richard-cox
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2965