Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where cookie domain name change can mean you can't log out #2732

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Fix issue where cookie domain name change can mean you can't log out #2732

merged 1 commit into from
Jul 25, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jul 24, 2018

Fixes #2730

@nwmac nwmac self-assigned this Jul 24, 2018
@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac changed the title Fix issue where cookie domain name means you can't log out Fix issue where cookie domain name change can mean you can't log out Jul 24, 2018
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #2732 into v2-master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #2732      +/-   ##
=============================================
- Coverage      70.05%   70.03%   -0.02%     
=============================================
  Files            599      599              
  Lines          25504    25504              
  Branches        5765     5765              
=============================================
- Hits           17866    17862       -4     
- Misses          7638     7642       +4

@nwmac nwmac requested a review from irfanhabib July 25, 2018 06:58
irfanhabib
irfanhabib approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@irfanhabib irfanhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irfanhabib irfanhabib merged commit e52e458 into v2-master Jul 25, 2018
@irfanhabib irfanhabib deleted the fix-can-not-log-out-cookie-domain branch July 25, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfanhabib irfanhabib irfanhabib approved these changes

Assignees

@nwmac nwmac

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwmac @cfdreddbot @irfanhabib