-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Experiment with Go dep and Go files in locations that match imports #2662
Conversation
Hey aeijdenberg! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2662 +/- ##
==========================================
Coverage 70.55% 70.55%
==========================================
Files 600 600
Lines 25583 25583
Branches 5786 5786
==========================================
Hits 18049 18049
Misses 7534 7534 |
Someone who understands these scripts should fix properly.
@nwmac - is this an approach that the Stratos team will consider adopting? (or are there other approaches that I can contribute to?) As it stands, I'm finding it very difficult to make Go contributions due to the non-standard build layout (as code editors don't understand it), so it would be great to get it into a more maintainable state. I've re-run the script in the gist to redo on latest |
@aeijdenberg Yes we are interested in this - I've not had a chance to take a look due to finishing up v2 testing. I have also been thinking about this - I was interested in whether go modules in 1.11 could also help here. |
@aeijdenberg The rationale for the current layout of the backend code, is to allow developers to contribute functionality (via backend go plugins) without having to fork the entire project or make changes to We recognise that this does make development a bit harder than it needs to be, since editors can't build and debug the code (since functionality is imported via plugins rather than packages). We're discussing how we can improve current model so that its easier to develop and debug backend extensions. We are actively looking at Go Modules as a possible solution. |
Thanks @irfanhabib - are there any docs or GitHub issues where we can learn more about the proposed changes? And in practice - are there many plugins being developed separately? |
@aeijdenberg I've created the issue to track this #2815. Yes, I am aware of one used by the Orange team in France. I believe it auto-registered several Cloud Foundry instances on startup. |
@aeijdenberg Thanks for the script and the work here - see #2815 - basically going with your suggestion with a slight change to the directory structure - I welcome your feedback. |
Closing as alternative was merged in #2854 |
See issue #2128 for information on how this commit was generated (script here: https://gist.github.com/aeijdenberg/2d8f6f473e567b834bede97bc557771f)