Update parent entities at validation time - the end of partial entities #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously when we fetch an entity/list of entities the validation process will fetch any missing parameters before the original entity/entities are stored. - for instance fetch a service instance, service is missing, fetch service and store in a service instance entity with it's only param, finally return with full service instance and store in store - these partial entities caused or were a catalist for a growing number of issues - issues such as we'd fire off entity changed events when updating, cascade calls where we'd try and populate itself and children repeatidly, etc - this commit now avoids the need to correct them by assigning the missing param at validation time
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2659 +/- ##
=============================================
+ Coverage 47.94% 47.95% +0.01%
=============================================
Files 597 597
Lines 25350 25338 -12
Branches 5735 5733 -2
=============================================
- Hits 12154 12151 -3
+ Misses 13196 13187 -9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ entity: { service: x} }) , finally return with full service instance and store in store ({ entity: { service: x, other: params, et: c} })