Aot #2594

KlapTrap · 2018-06-29T15:17:36Z

Fix up the app to allow for our app to be built with aot enabled.

cfdreddbot · 2018-06-29T15:17:37Z

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

* v2-master: (31 commits) RC2 Changelog Apply `connected` fix to marketplace wall as well Filter for connected endpoints Remove testing code Clear up service instances pagination after disconnecting an endpoint Fix bug in reducer Change schedular of application step 1 validated observable to avoid zone issues Revert "Horrible work around for ExpressionChangedAfterItHasBeenCheckedError" Fix typo in button id Horrible work around for ExpressionChangedAfterItHasBeenCheckedError - We've got the `valid` pattern wrong in the steppers, the steps are child components and change the state of their parent components - Added this workaround, but we should think about changing this pattern (not sure how though, given that each step controls it's own valid state) - Have also tested other steppers for the same issue and this looks like the only one Fix e2e-tests Fix indentation Add e2e-tests branch Fix artifact upload Fix missing package. Only run e2e tests for testing Add screenshot reporter for test failures. Upload e2e test report to s3. Test Try fix for slower test execution Fix create app step 'valid' which disabled stepper next in production - In production the statusChanges emits before we watch it for the result - when we start watching it doesn't emit the now valid form state - only seen in production when navigating to stepper, not when loading stepper Fixed space delete and issue with entity service ...

codecov · 2018-06-29T15:41:25Z

Codecov Report

Merging #2594 into v2-master will decrease coverage by 0.04%.
The diff coverage is 81.35%.

@@              Coverage Diff              @@
##           v2-master    #2594      +/-   ##
=============================================
- Coverage       70.1%   70.06%   -0.05%     
=============================================
  Files            599      599              
  Lines          25515    25482      -33     
  Branches        5783     5757      -26     
=============================================
- Hits           17888    17853      -35     
- Misses          7627     7629       +2

richard-cox

Gone through code and had some questions/issues. Struggling to get it to run locally though.

richard-cox · 2018-07-02T12:18:00Z

...ntend/app/shared/components/list/list-table/table-cell-radio/table-cell-radio.component.html

@@ -1 +1 @@
-<mat-radio-button [disabled]="(dataSource.isAdding$ | async) || disable" (change)="dataSource.selectedRowToggle(row, false)" [checked]="dataSource.selectedRows?.has(dataSource.getRowUniqueId(row))"></mat-radio-button>
+<mat-radio-button [disabled]="(dataSource.isAdding$ | async) || disable" (change)="dataSource.selectedRowToggle(row)" [checked]="dataSource.selectedRows?.has(dataSource.getRowUniqueId(row))"></mat-radio-button>


There's a mistake in the interface for selectedRowToggle, it should have an optional second parameter that defaults to true (see list.data.source).

richard-cox · 2018-07-02T12:23:26Z

src/frontend/app/shared/data-services/cf-org-space-service.service.ts

  ) {
    // Note - normal optional parameter notation won't work with injectable
-    this.selectMode = _selectMode || this.selectMode;
+    this.selectMode = this.selectMode;


If we're not setting this via constructor it doesn't need to be set here.

richard-cox · 2018-07-02T12:35:37Z

src/frontend/app/shared/components/list/list-cards/cards.component.ts


 @Component({
  selector: 'app-cards',
  templateUrl: './cards.component.html',
  styleUrls: ['./cards.component.scss']
 })
 export class CardsComponent<T> {
+  public columns = CardCell.columns;


This breaks CfEndpointCardComponent which overrides the static component.columns/CardCell.columns
Update - this is ok with latest solution

- See cf's page (multiple connected endpoints)

richard-cox

After adding a custom start target this worked fine for me.
From a purely 'does it work' perspective the PR looks fine.

KlapTrap · 2018-07-18T15:44:20Z

We need another npm target that builds the app without aot and @richard-cox was going to add a target that will run the dev build with an increased memory limit. We might want to document those new targets too.

* v2-master: (101 commits) More tidy up Tidied up some code linting fix Tweaks as per discussion, also upped page size from 50 to 100 for permissions fetch Fix tests Linting Flatten pagination for current user permission fetching Ensure lists with no entities populate pagination section correctly - ids: { } => ids: { 1: [] } - think this is a regression following the removal of partial entities - Fixes #2682, #2684 Make flattenPagination generic Add note about memory usage Clean up whitespace Ensure we don't worry about empty page request infos if we already have is list Fix for add org button vanishing Fix unit tests Fix cc Improve styling of new chips button Fix click action interferring with scroll bar Minor tidy ups Use subtle mode by default for the boolean indicator Add support for new SCF Config LB property ...

Fix up the app to allow for our app to be built with aot enabled. Fixes #2201

KlapTrap added 4 commits June 28, 2018 21:40

Ensure we return a clean EntityInfo from entity service

0cef860

WIP Aot fixes

ff38484

WIP Fixing aot template errors

94a602d

Fix up inports and use inject tokens

6f4eb58

KlapTrap added the in progress label Jun 29, 2018

KlapTrap self-assigned this Jun 29, 2018

KlapTrap added 2 commits June 29, 2018 16:24

Test entity service provider fixed

8fae526

Test fix

7339dc3

KlapTrap added ready for review and removed in progress labels Jun 29, 2018

nwmac requested review from nwmac and richard-cox July 2, 2018 10:05

richard-cox suggested changes Jul 2, 2018

View reviewed changes

Fixed issues after adding aot

3f78935

KlapTrap added the comments-addressed label Jul 3, 2018

richard-cox added 3 commits July 4, 2018 11:18

Fix table radio select (see bind existing route)

f6af89a

Fix custom cards list columns

08ac00d

- See cf's page (multiple connected endpoints)

Add npm script to run start with max_old_space_size

b62d673

richard-cox approved these changes Jul 4, 2018

View reviewed changes

Remove source maps from serve

ff8eefe

KlapTrap added needs attention This PR needs attention and removed comments-addressed ready for review labels Jul 18, 2018

nwmac and others added 2 commits July 19, 2018 10:16

tidy up preserve sym links

2682146

KlapTrap merged commit 4bf1710 into v2-master Jul 19, 2018

KlapTrap deleted the aot branch July 19, 2018 10:14

irfanhabib pushed a commit that referenced this pull request Jul 19, 2018

Aot (#2594)

29b969e

Fix up the app to allow for our app to be built with aot enabled. Fixes #2201

KlapTrap mentioned this pull request Aug 13, 2018

Investigate creating prebuilt frontend package #2822

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aot #2594

Aot #2594

KlapTrap commented Jun 29, 2018 •

edited

Loading

cfdreddbot commented Jun 29, 2018

codecov bot commented Jun 29, 2018 •

edited

Loading

richard-cox left a comment

richard-cox Jul 2, 2018

richard-cox Jul 2, 2018

richard-cox Jul 2, 2018 •

edited

Loading

richard-cox left a comment •

edited

Loading

KlapTrap commented Jul 18, 2018

		@@ -1 +1 @@
		<mat-radio-button [disabled]="(dataSource.isAdding$ \| async) \|\| disable" (change)="dataSource.selectedRowToggle(row, false)" [checked]="dataSource.selectedRows?.has(dataSource.getRowUniqueId(row))"></mat-radio-button>
		<mat-radio-button [disabled]="(dataSource.isAdding$ \| async) \|\| disable" (change)="dataSource.selectedRowToggle(row)" [checked]="dataSource.selectedRows?.has(dataSource.getRowUniqueId(row))"></mat-radio-button>

Aot #2594

Aot #2594

Conversation

KlapTrap commented Jun 29, 2018 • edited Loading

cfdreddbot commented Jun 29, 2018

codecov bot commented Jun 29, 2018 • edited Loading

Codecov Report

richard-cox left a comment

Choose a reason for hiding this comment

richard-cox Jul 2, 2018

Choose a reason for hiding this comment

richard-cox Jul 2, 2018

Choose a reason for hiding this comment

richard-cox Jul 2, 2018 • edited Loading

Choose a reason for hiding this comment

richard-cox left a comment • edited Loading

Choose a reason for hiding this comment

KlapTrap commented Jul 18, 2018

KlapTrap commented Jun 29, 2018 •

edited

Loading

codecov bot commented Jun 29, 2018 •

edited

Loading

richard-cox Jul 2, 2018 •

edited

Loading

richard-cox left a comment •

edited

Loading