Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client and client secret issues when pushing apps #2553

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 27, 2018

Fixes app push failure if not using default client and client secret.

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #2553 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #2553   +/-   ##
==========================================
  Coverage      70.42%   70.42%           
==========================================
  Files            594      594           
  Lines          25132    25132           
  Branches        5674     5674           
==========================================
  Hits           17698    17698           
  Misses          7434     7434

@nwmac nwmac requested a review from irfanhabib June 28, 2018 09:55
Copy link
Contributor

@irfanhabib irfanhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irfanhabib irfanhabib merged commit 42b51bd into v2-master Jun 28, 2018
@irfanhabib irfanhabib deleted the fix-app-push-client branch June 28, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants