Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure requests to multiple endpoints continue if one fails #2498

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Ensure requests to multiple endpoints continue if one fails #2498

merged 2 commits into from
Jun 22, 2018

Conversation

richard-cox
Copy link
Contributor

  • Relevant to app/service instance wall and orgs fetch used by filters
  • Multi-endpoint requests - Red error bar shows for failed endpoint, the result of other successful endpoints are processed
  • Single-endpoint requests - Red error bar shows, lists not shown

Fixes #2456

@richard-cox
Ensure requests to multiple endpoints continue if one fails
7a30d90 
- Relevent to app/service instance wall, initial orgs fetch
- Multi-endpoint requests - Red error bar shows for failed endpoint, other successfull endpoint results processed
- Single-endpoint requests - Red error bar shows, lists not shown
@richard-cox richard-cox self-assigned this Jun 21, 2018
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 21, 2018 •
edited
Loading

Codecov Report

Merging #2498 into v2-master will decrease coverage by 0.06%.
The diff coverage is 52.94%.

@@              Coverage Diff              @@
##           v2-master    #2498      +/-   ##
=============================================
- Coverage      70.69%   70.63%   -0.07%     
=============================================
  Files            590      590              
  Lines          24852    24835      -17     
  Branches        5611     5610       -1     
=============================================
- Hits           17569    17542      -27     
- Misses          7283     7293      +10

nwmac
nwmac approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Will merge as soon as gate checks pass

nwmac
nwmac approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit fb11e43 into v2-master Jun 22, 2018
@nwmac nwmac deleted the skip-failed-endpoint branch June 22, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
in review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac