Show users without usernames #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes - no users shown in ibm cloud when using https://api.<region>.bluemix.net - Fixes - in scf missmatch between user count and users in users table - Step backward - Shows three extra users in scf users table. - Two `inactive` users that do not contain a username - One 'active' user that does not contain a username and who's guid is `hcf_auto_config`
- We now ensure all users have guids, acquired from their guid - This means the hcf_auto_config user is shown again - Ensure this user is blocked, so no org/space roles can be assigned - Wired in same blocking mechanism to manager users select users step
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2496 +/- ##
=============================================
- Coverage 70.69% 70.65% -0.05%
=============================================
Files 590 590
Lines 24852 24822 -30
Branches 5611 5611
=============================================
- Hits 17569 17537 -32
- Misses 7283 7285 +2 |
nwmac
suggested changes
Jun 22, 2018
| const rowStateManager = new TableRowStateManager(); | ||
| const sub = paginationMonitor.currentPage$.pipe( | ||
| tap(users => { | ||
| users.forEach(user => { | ||
| rowStateManager.setRowState(user.metadata.guid, { | ||
| blocked: !user.entity.username | ||
| blocked: user.metadata.guid === 'hcf_auto_config' || user.metadata.guid === 'scf_auto_config' |
There was a problem hiding this comment.
I don't think we should special-case SCF users.
- Don't make special case of auto_config user - This will only be visible to cf admins... unless they assign roles to it
richard-cox
added
comments-addressed
in progress
and removed
question
comments-addressed
labels
nwmac
reviewed
Jun 22, 2018
deploy/README.md
Outdated
| 2. Kubernetes, using a Helm chart. See [guide](kubernetes) | ||
| 3. Docker, using docker compose. See [guide](docker-compose) | ||
| 4. Docker, single container deploying all components. See [guide](all-in-one) | ||
| 1. Cloud Foundry, as an application. See [guide](cloud-foundry/README) |
There was a problem hiding this comment.
I don't think these links work with the added README - what was the reason for change? We have the same links in the main README as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all users have a username, use the guid when missing
Fixes #2463