Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve backend error handling with passthrough #2407

Merged
merged 2 commits into from
Jun 18, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 18, 2018

Fix bug with error being serialized as a string not JSON.

Refactored to remove error-prone JSON string creation and replace with structs

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac changed the title Fix and improve backend error hadnling with passthrough Fix and improve backend error handling with passthrough Jun 18, 2018
@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #2407 into v2-master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #2407      +/-   ##
=============================================
- Coverage      71.13%   71.11%   -0.02%     
=============================================
  Files            582      582              
  Lines          24398    24398              
  Branches        5467     5467              
=============================================
- Hits           17355    17351       -4     
- Misses          7043     7047       +4

@irfanhabib irfanhabib merged commit 0ed4308 into v2-master Jun 18, 2018
@irfanhabib irfanhabib deleted the backend-error-handling branch June 18, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants