Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few UX issues #2394

Merged
merged 3 commits into from
Jun 18, 2018
Merged

Fix a few UX issues #2394

merged 3 commits into from
Jun 18, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 15, 2018

This PR fixes #2344:

  • Changes the spacing on the stepper to use padding rather than margin, so that checkboxes don't have their ripple effect cropped
  • Tweaks down the padding and font sizes on the small card
  • Adds a capitalize first pipe and uses this on the org card so that the status reads Active and not active
  • Fixed the highlighted table row so that it is not indented
  • Fixed an overflow issue with table rows, where longs rows - such as the STRATOS_PROJECT value on the env vars table does not cause the table to overflow off the screen
  • Swapped the org/space with the created field on the app card
  • Changed stepper style so that only the active step is marked in bold and not the previous compelted steps

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac self-assigned this Jun 15, 2018
@nwmac nwmac added the V2 label Jun 15, 2018
@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #2394 into v2-master will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #2394      +/-   ##
=============================================
- Coverage         71%   70.99%   -0.01%     
=============================================
  Files            582      583       +1     
  Lines          24362    24379      +17     
  Branches        5466     5472       +6     
=============================================
+ Hits           17298    17308      +10     
- Misses          7064     7071       +7

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FWIW There's a titlecase pipe that would have done the same thing as capitalizeFirst (as long as the status was always a single word). Keeping in as this could be handy in the future.

@richard-cox richard-cox merged commit fa3f1f7 into v2-master Jun 18, 2018
@richard-cox richard-cox deleted the ux-tweaks branch June 18, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not create TCP Route
3 participants