Make sure the expiry date time is relative to the time as the client sees it #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
changed the title
richard-cox
suggested changes
Oct 16, 2017
components/app-core/backend/auth.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
Should lines 106-114 also get the chop?
There was a problem hiding this comment.
Yes, they should...hmmm... not sure how that happenned... good spot!
There was a problem hiding this comment.
Pushed a new commit that removes these lines.
richard-cox
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client now sends the time as it sees it in a custom header.
The backend will return the session expiry as a timestamp based on the client's timestamp.
The original error occurs when someone changes the time by modifying the time itself rather than changing the timezone - e.g. if you were in Prague, you leave the timezone as London, but manually add 1 hour to the time.