Enable binding of mysql db service to CF hosted console #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
approved these changes
Oct 3, 2017
| @@ -21,6 +21,7 @@ type VCAPCredential struct { | |||
| Username string `json:"username"` | |||
| Password string `json:"password"` | |||
| Dbname string `json:"dbname"` | |||
| name string `json:"name"` | |||
There was a problem hiding this comment.
Can we case this "Name", so it is consistent.
| db.Password = dbCredentials.Password | ||
| db.Database = dbCredentials.name | ||
| db.Host = dbCredentials.Hostname | ||
| db.Port, err = strconv.Atoi(dbCredentials.Port) |
There was a problem hiding this comment.
You're not using "err, so you should use underscore (_).
| 1. Create a Service Instance for the Console Database | ||
|
|
||
| Use `cf create-service` to create a service instance for the Postges DB - for example: | ||
| > **NOTE** The console supports postgresql and mysql DBs. Your service instance must be tagged with either `stratos_postgresql` for postrgresql or `stratos_mysql` for mysql. |
| return false | ||
| } | ||
|
|
||
| for _, services := range vcapServices { | ||
| if len(services) == 0 { | ||
| continue | ||
| } | ||
|
|
||
| service := services[0] |
There was a problem hiding this comment.
This assumes only one service instance of any given type is bound - which is probably fine, but we could iterate through them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.