Service params editing #1253
Merged
Service params editing #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binding to an application
richard-cox
suggested changes
Sep 18, 2017
There was a problem hiding this comment.
Another quick review before the update
- bind service instance modal
- newServiceInstance is not defined error on clicking add (on line newServiceInstance.name = undefined;)
- create service instance modal
- enter text for a tag, but don't hit return/defocus, then click edit. the tags input box is shown above the new pop up
- create service instance service parameters modal
- The text block input focus is blue
- There's no feedback when invalid json is ignored. It would be good to have the standard 'invalid input' input field error.
richard-cox
suggested changes
Sep 20, 2017
| @@ -31,9 +31,14 @@ | |||
| name: userInput.name, | |||
There was a problem hiding this comment.
Typo in file name... create-servince-instance.service.js
| <div ng-if="wizardCtrl.options.editParams" class="async-dialog-param-editor" ng-class="{'param-editor-open' : wizardCtrl.options.editParams}"> | ||
| <form name="form.paramEditor" class="async-dialog-param-editor param-editor-container"> | ||
| <div class="form-group json-input-field" focusable-input ng-model-options="{ debounce: 200 }" ng-class="{'has-error': form.paramEditor.$invalid && form.paramEditor.$dirty}"> | ||
| <label class="control-label" translate>app.app-info.app-tabs.services.create.service-params</label> |
There was a problem hiding this comment.
Sorry, late comment... instead of 'Parameters' could we call this 'Binding Parameters' and in the create instance dialog 'Instance Parameters'?
richard-cox
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.