Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect caching and reset behaviour of app wall filters #1248

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Fix incorrect caching and reset behaviour of app wall filters #1248

merged 1 commit into from
Sep 7, 2017

Conversation

richard-cox
Copy link
Contributor

  • Ensure that when we reset dodgy cluster/org values we also reset org/space
  • Previously we were showing filter by 'all' for org/space but still applying filter containing valid org/space guid
  • Reset fixed by not entering dodgy state

@richard-cox
Fix incorrect caching and reset behaviour of app wall filters
0f2cc8a 
- Ensure that when we reset dodgy cluster/org values we also reset org/space
- Previously we were showing filter by 'all' for org/space but still applying filter containing valid org/space guid
- Reset fixed by not entering dodgy state
nwmac
nwmac approved these changes Sep 7, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 2020afa into master Sep 7, 2017
@nwmac nwmac deleted the fix-app-filter-cache branch September 7, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac