Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-sort service instances in cloud foundry space instances table #1233

Merged
merged 2 commits into from
Aug 25, 2017

Conversation

richard-cox
Copy link
Contributor

  • Pre sort cluster space service instance table to avoid visual blip of unsorted entries
  • Only show the 'no instances' message when we have no instances (not before the instances have been fetched)

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 47c8c18 into master Aug 25, 2017
@nwmac nwmac deleted the pre-sort-service-instances branch August 25, 2017 11:10
KlapTrap added a commit that referenced this pull request Aug 29, 2017
* master:
  Pre-sort service instances in cloud foundry space instances table (#1233)
  Remove package-lock.json - to be added back in another pr
  Add sass source maps into the dev build of the frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants