Optionally enable endpoints-dashboard via env var for use in cf push #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Aug 15, 2017
•
richard-cox
commented
- Disable the endpoint-dashboard at runtime if env var is present
- Plugins can now add config to the console-info call
- endpoint-dashboard now has a backend component
- If env var 'DISABLE_ENDPOINT_DASHBOARD' is present add 'disabled' to component config
- Handle disabled dashboard in frontend..
- Do not add to menu
- Do not redirect to dashboard if no endpoints present
- Remove from env.plugins
- Fixed endpoint dashboard 'on logged in' message for admin's when there are no connected endpoints
- Speed up logged in process by making calls async
- Improved unit tests
- Plugins can now add config to the console-info call - Add backend component to endpoint-dashboard -- If env var 'DISABLE_ENDPOINT_DASHBOARD' is present add 'disabled' to component config - Handle disabled dashboard in frontend.. -- Do not add to menu -- Do not redirect to dashboard if no endpoints present -- Remove from env.plugins - Fixed endpoint on logged in message for admin's when there are no connected endpoints - Speed up logged in process by making 3 calls async - Improved unit tests
- Switch logic from 'disable' flag to 'enable' (true by default) - Updated docs - Prooved cf push with/wuthout flag
nwmac
suggested changes
Aug 18, 2017
| function init() { | ||
| return initialized.promise; | ||
| } | ||
| var config = {}; |
There was a problem hiding this comment.
Remove config object
change updateConfig to be isDashboardDisabled() that returns the value
| function onLoggedIn() { | ||
| var menu = modelManager.retrieve('app.model.navigation').menu; | ||
| menu.addMenuItem('endpoints', 'endpoint.dashboard', 'menu.endpoints', 2, 'settings_input_component'); | ||
| initialized.resolve(); | ||
| } | ||
|
|
||
| function getDashboardRedirect() { |
There was a problem hiding this comment.
can we consider a clearer name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.