-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO Auth Doesn't Work for Endpoints #4716
Comments
Hi @thomasmitchell , was just trying to give this a test but hit some environment issues. Could I confirm you're seeing this after checking out the |
yes, It looks like it happened in #4555 In the interim, we've manually patched our compilation of the frontend for this line:
to reference |
Odd, the |
Line 1027 in 86b6633
Notably, the SSO endpoint is nested into the |
Please accept my apologies, serious case of read the issue. I was confusing the POST with GET, and you clearly stated GET at start. Understand the issue now, we'll look at fixing this in a patch release |
thank you very much :) |
- this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes #4716 - test both endpoint and stratos SSO log in
* Move GET `/tokens` into `api` group - this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes #4716 - test both endpoint and stratos SSO log in * Ensure travis runs on the new branch (will be removed after release)
Fixed via #4719. This will be in the 4.2.1 release which should be out this week. |
* Move GET `/tokens` into `api` group (cloudfoundry#4719) * Move GET `/tokens` into `api` group - this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes cloudfoundry#4716 - test both endpoint and stratos SSO log in * Ensure travis runs on the new branch (will be removed after release) * Update version, change log and package lock for 4.2.1 (cloudfoundry#4720) * Fixes following merge
4.2.1 has now been released |
* Move GET `/tokens` into `api` group (#4719) * Move GET `/tokens` into `api` group - this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes #4716 - test both endpoint and stratos SSO log in * Ensure travis runs on the new branch (will be removed after release) * Update version, change log and package lock for 4.2.1 (#4720) * Update .travis.yml
* Merge upstream (#533) * Move GET `/tokens` into `api` group (cloudfoundry#4719) * Move GET `/tokens` into `api` group - this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes cloudfoundry#4716 - test both endpoint and stratos SSO log in * Ensure travis runs on the new branch (will be removed after release) * Update version, change log and package lock for 4.2.1 (cloudfoundry#4720) * Fixes following merge * Update .travis.yml
Stratos Version
4.2.0
Frontend Deployment type
Backend (Jet Stream) Deployment type
Expected behaviour
Performing SSO auth to a CF endpoint should redirect to the SSO token page.
Actual behaviour
The frontend returns a 405 Method Not Allowed.
Steps to reproduce the behavior
Log output covering before error and any error statements
Additional notes
Jetstream listens for SSO auth as of the latest version at
GET /pp/v1/auth/tokens
, but the frontend attempts to reach it onGET /api/v1/tokens
. This gets picked up by the non-SSO auth handler, which only responds toPOST
methods, hence the 405 error code response from the routing library. Unsure if by design that the backend or frontend path is correct, so I've held off on a PR, but the fix depends on the two agreeing on the path.The text was updated successfully, but these errors were encountered: