Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Button Misaligned #4316

Closed
richard-cox opened this issue May 28, 2020 · 0 comments · Fixed by #4317
Closed

User Button Misaligned #4316

richard-cox opened this issue May 28, 2020 · 0 comments · Fixed by #4317
Labels
Milestone

Comments

@richard-cox
Copy link
Contributor

image

  • Seen in Chrome 83.0.4103.61 (and up to date Safari?)
  • Fine in Chromium 81.0.4044.92
  • button element (40x40) contains span mat-button-wrapper (30x30)
  • In older browser inner child is vertically aligned centrally, in new it's align to top
@richard-cox richard-cox added this to the 3.3.0 milestone May 28, 2020
richard-cox added a commit that referenced this issue May 28, 2020
@richard-cox richard-cox modified the milestones: 3.3.0, 3.2.1 May 28, 2020
richard-cox added a commit that referenced this issue May 29, 2020
richard-cox added a commit to SUSE/stratos that referenced this issue Jun 4, 2020
* Add initial UI for backup/restore

* Convert connection details checkbox to drop down

* Add docs for max list feature

* Add db version check

* Tidy up #1

* Tidying & bug fixes. Handle client_secret

* Add minimum password length

* First pass encrypt/decrypt

* Tidy up

* Fix unit tests

* Re-add tests that now work

* Changes following review

* Move backup into it's own module

* Ensure we filter out maxed results for local lists
- When apps collection is fetched and exceeds maxed allowed certain monitor observables were still firing with the partial collection of apps
- This led to app based stats (like count and memory) to be shown on the space cards & summary
- This was caused by a correction to the pagination monitor to use 'local' monitor observables instead of non-local
- The now correct observable to use did not have a filter for maxed results, so emited the bad data

* CF Push: Ensure we refresh token

* Fix uaa docs. Make UAA endpoint config simpler

* Fix compile issues

* Helm Chart: Fix Helm 3 compatibility with Release.Time

* Add nodeSelector implementation and tests to kubernetes helm deployment. (cloudfoundry#4252)

* Add nodeSelector template and tests

Add nodeSelector template to the helm deployment:
- deployment.yaml
- database.yaml
- config-init.yaml

Add tests to validate nodeSelector template to
- deployment_test.yaml

Create tests to validate nodeSelector template to
- database_test.yaml
- config_init_test.yaml

* Add c&p fix and another nodeSelector test

Add fix for c&p bug to
- database.yaml
- deployment.yaml

Add test to validate nodeSelector template to
- config_init_test.yaml

Add test config to
- database-test.yaml
- deployment-test.yaml

* Remove test

Remove test to validate nodeSelector template to
    - config_init_test.yaml

* Autoscaler improvements

* Fix disabling of polling (cloudfoundry#4260)

- fixes cloudfoundry#4244

* Add Helm 3 lint check to the Travis Helm Chart job (cloudfoundry#4263)

* Helm Chart: Fix Helm 3 compatibility with Release.Time

* Add helm 3 lint

* Increase users table page size before searching for `e2e` user

* Helm node selector docs and values (cloudfoundry#4264)

* Add nodeSelector template and tests

Add nodeSelector template to the helm deployment:
- deployment.yaml
- database.yaml
- config-init.yaml

Add tests to validate nodeSelector template to
- deployment_test.yaml

Create tests to validate nodeSelector template to
- database_test.yaml
- config_init_test.yaml

* Add c&p fix and another nodeSelector test

Add fix for c&p bug to
- database.yaml
- deployment.yaml

Add test to validate nodeSelector template to
- config_init_test.yaml

Add test config to
- database-test.yaml
- deployment-test.yaml

* Remove test

Remove test to validate nodeSelector template to
    - config_init_test.yaml

* More gates on node selector. Added to values.yaml and README

Co-authored-by: Johannes Jungkunst <macevil@gmail.com>

* Disable random route override setting when deploying apps in e2e tests
- pushes route over max 63 chars

* Override name but do not set a random route

* EE Test improvements (cloudfoundry#4274)

* Speed up form fill

* Manage users fix?

* Wait slightly longer

* Improve error output in tests

* Fix invite users error msg check

* Fix manage users e2e

* Need checked in form to check box correctly

* Fix row highligh & Improve metrics summary view (cloudfoundry#4270)

* Fix row highlight (see app github tab commit table)
- wasn't showing after list in list changes
- fixes cloudfoundry#4243

* Improve metrics view

* Fix code climate issues

* Fix 2 more code climate issues

* Fix merge issue

* Fix dark mode box shadow
- dark mode styling overode disabling of box shadow

* Fix multiple metrics requests due to recreated list cards

* Fix most additional /stratos requests on load of endpoints page with metrics

* Fix unit tests

* Fix EndpointCardComponent test

* Fix root list colour in metrics summary page dark mode

* Fix first row alignment in users table

* Fix invite user e2e test (see cloudfoundry#4272)

* Disable random route override setting when deploying apps in e2e tests
- pushes route over max 63 chars

Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>

* Improve view that shows details for a metrics endpoint (cloudfoundry#4258)

* Improve metrics view

* Fix code climate issues

* Fix 2 more code climate issues

* Fix merge issue

* Fix multiple metrics requests due to recreated list cards

* Fix most additional /stratos requests on load of endpoints page with metrics

* Fix unit tests

* Fix EndpointCardComponent test

Co-authored-by: Richard Cox <richard.cox@suse.com>

* Fix row highlight (see app github tab commit table) (cloudfoundry#4257)

* Fix row highlight (see app github tab commit table)
- wasn't showing after list in list changes
- fixes cloudfoundry#4243

* Fix dark mode box shadow
- dark mode styling overode disabling of box shadow

Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>

* E2E Cleanup script: clean other users (cloudfoundry#4269)

* E2E Cleanup script: clean other users and reduce time to 1 hour

* Remove superfluous blank lines

* Revert back to 2 hours

* Version bump and change log for 3.2.0

* E2E Test improvements (cloudfoundry#4275)

* Speed up form fill

* Fix page set setting

* Remove whitespace

* Add ability to provided a wildcard in path when matching urls (cloudfoundry#4277)

* Update releas notes

* Only show metrics details on endpoint card/list when connected

* Fix icon alignment on service marketplace view

* Fix issue where user profile was fetched repeatidly (cloudfoundry#4285)

- remove calls to fetchUserProfile
- ensure entity service is used instead of monitor (will fetch profile)
- update FetchUserProfileAction action to a EntityRequestAction
- there's no response to update profile, so ensure we fetch profile again afterwards
- also fixed issue where metrics endpoint reporting a k8s endpoint would cause a console.error

* CF Push: A better fix for the token expiry issue

* Update changelog for 3.2.0 (cloudfoundry#4291)

* Fix misaligned user button
- fixes cloudfoundry#4316

* Temporarily add branch v3.2.1 to travis

* check sso whitelist in more places

Signed-off-by: Ben Berry <ben.berry@gsa.gov>

* refactor sso state checks into single function

Signed-off-by: Ben Berry <ben.berry@gsa.gov>

* Update version

* First pass at changelog (additional SSO fix required)

* Update changelog

* Fixes after merge

* Remove v3.2.1 branch from travis

* Changes following review

* Ensure browser.baseUrl doesn't end with /

Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com>
Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
Co-authored-by: macevil <30493519+macevil@users.noreply.github.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
Co-authored-by: Johannes Jungkunst <macevil@gmail.com>
Co-authored-by: Ben Berry <ben.berry@gsa.gov>
nwmac added a commit to SUSE/stratos that referenced this issue Jun 23, 2020
* WIP

* First pass at permission effects

* First pass at reducer

* Final set of cloud-foundry code out of common

* Renames, todos

* Minor fixes

* Fix unit tests

* Tweaks

* Finish todos

* Fix transition from space summary to app summary page
- an entity service for a space with no org was cached by guid
- an entity service for a space requiring org used cached version
- solution is to make cache id include schema key (determines with/without org)

* Add comment, tidy up rootUpdatingKey

* Fix issue where gitlab summary tab threw errors in console
- fixes cloudfoundry#4325

* Fix misaligned user button
- fixes cloudfoundry#4316

* Temporarily add branch v3.2.1 to travis

* check sso whitelist in more places

Signed-off-by: Ben Berry <ben.berry@gsa.gov>

* refactor sso state checks into single function

Signed-off-by: Ben Berry <ben.berry@gsa.gov>

* Update version

* First pass at changelog (additional SSO fix required)

* Update changelog

* Push combine of permission configs into checkers
- overcomes some weird change of permission type

* Fix issue where default add/remove setting in change role by username was incorrect
- add/remove radio button default value governed by add/remove feature flags
- when one is set to false the radio button should be disabled and the other selected

* Fix store-test-helper

* Fix package-lock.json

* Remove v3.2.1 was .travis.taml

* Remove need for --recreate-pods when upgrading

* Update readme following move to Travis-ci.com

* Add support for helm chart customizations

* Removed change not needed

* Ensure the correct key is used metacard favourite info (cloudfoundry#4321)

* Fix display of details in endpoint card in endpoint list (cloudfoundry#4319)

* Clean default/blocked logic

* Rename @Stratos to @stratosui

* FIx references in tsconfig.json

* Fix endpoint connect

* Fix unit test

* Fix e2e test

* Change following review #1

* Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (cloudfoundry#4199)

* Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream

Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/gorilla/websocket/releases)
- [Commits](gorilla/websocket@v1.4.1...v1.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update go.sum

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>

* Fix errors in console log during setup screens

* Helm: Change default image pull policy to Always

* Add copy address and edit to endpoint list view

* Use icon that is less confusing with refresh

* Change following review #2
- Fix cf package module file name
- Make CUSTOM_USER_PERMISSION_CHECKERS optional
- Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules

* Add newline at end for codeclimate

* Fix for buildpack filename wrapping on card

* Fix code climate issue

* Update endpoint-list.helpers.ts

* Improve naming

* Tidy up

* Change following review

* Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (cloudfoundry#4336)

* Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream

Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0.
- [Release notes](https://github.com/go-yaml/yaml/releases)
- [Commits](go-yaml/yaml@v2.2.8...v2.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* CI bump

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com>

* [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (cloudfoundry#4356)

Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.**
- [Release notes](https://github.com/faye/websocket-extensions-node/releases)
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md)
- [Commits](faye/websocket-extensions-node@0.1.3...0.1.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Fail CI build if imagelist generation fails

* Updated __stratos.tpl as per changes in deploy/kubernetes/console/templates/deployment.yaml

* Fix build

* Helm Chart: Icon is missing
- fixes #393

* Fixes following review

Co-authored-by: Ben Berry <ben.berry@gsa.gov>
Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com>
richard-cox added a commit to SUSE/stratos that referenced this issue Jun 23, 2020
* Fix misaligned user button
- fixes cloudfoundry#4316

* Temporarily add branch v3.2.1 to travis

* check sso whitelist in more places

Signed-off-by: Ben Berry <ben.berry@gsa.gov>

* refactor sso state checks into single function

Signed-off-by: Ben Berry <ben.berry@gsa.gov>

* Update version

* First pass at changelog (additional SSO fix required)

* Update changelog

* Fix package-lock.json

* Remove v3.2.1 was .travis.taml

* Remove need for --recreate-pods when upgrading

* Add support for helm chart customizations

* Removed change not needed

* Apply recreate-pods fix to SUSE additional containers

Co-authored-by: Richard Cox <richard.cox@suse.com>
Co-authored-by: Ben Berry <ben.berry@gsa.gov>
Co-authored-by: Richard Cox <richard-cox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant