Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make permissions model extension friendly #3789

Closed
richard-cox opened this issue Aug 20, 2019 · 0 comments · Fixed by #4314
Closed

Make permissions model extension friendly #3789

richard-cox opened this issue Aug 20, 2019 · 0 comments · Fixed by #4314
Labels
extensions
Milestone
4.0.0

Comments

@richard-cox
Copy link
Contributor

richard-cox commented Aug 20, 2019 •
edited
Loading

Pull out cf specific code from permissions model

Review src/frontend/packages/store/src/reducers/current-user-roles-reducer. A lot of this is cf related. Need to understand if the generic permissions model depends on any. If not move over. If so need to understand how to make permissions model work with packages.

UPDATE: The currentUserRoles part of the store contains three seconds, two are core and one is specifically cf. Need to move this out of currentUserRoles such that we don't have two reducers for the same store section. The permissions model should be expanded to allow extensions to add their own permission checks (which look in new cf current user roles part of store)
@richard-cox richard-cox mentioned this issue Aug 20, 2019
Closed
richard-cox added a commit that referenced this issue Aug 20, 2019
@richard-cox
Remove some duped reducers
5b0b046 
- all other cf specific reducers/functions should move out following #3789
@richard-cox richard-cox mentioned this issue Aug 20, 2019
Merged
KlapTrap added a commit that referenced this issue Aug 21, 2019
@KlapTrap
Merge branch 'v3-master' into fix-lint
147f420 
* v3-master:
  Remove some duped reducers - all other cf specific reducers/functions should move out following #3789
KlapTrap added a commit that referenced this issue Aug 21, 2019
@KlapTrap
Merge branch 'v3-master' into merge-v2-master
b92ba0a 
* v3-master:
  Temp fix for linting
  Remove some duped reducers - all other cf specific reducers/functions should move out following #3789
  Fix linting
KlapTrap added a commit that referenced this issue Aug 21, 2019
@KlapTrap
Merge branch 'v3-master' into fix-metrics
a278bdc 
* v3-master:
  Fix quotas
  Fix post merge
  Temp fix for linting
  Remove some duped reducers - all other cf specific reducers/functions should move out following #3789
  Fix linting
  Fix three quota issues (#3782)
  Bump version and add changelog for 2.5 (#3765)
  Fix SSO tests
  Don't load demo plugin
  Remove demo plugin
  Don't send registration info in query string
  Added fav reducers back
  Don't send username/password in the URL
  Fix bug where setup is not saved and fix /uaa after setup
  Add apache2 utils to nginx package
KlapTrap added a commit that referenced this issue Aug 22, 2019
@KlapTrap
Merge branch 'v3-master' into entity-catalogue-fix-cf-unit-tests
01f0e3f 
* v3-master:
  Fix quotas
  Fix post merge
  Temp fix for linting
  Remove some duped reducers - all other cf specific reducers/functions should move out following #3789
  Fix linting
  Fix autoscaler events page
  Fix typo
  Removed comments
  Fix multiple autoscaler issues - fix charts view (including metrics tiem range selector) - ensure error is shown correctly on edit failure - ensure 404 error is not shown after policy creation - bug - Fix autoscaler events table #3783
  Fix metrics - Ensure metrics actions take in endpoint type   - cfMetrics for cf specific actions, downstream metrics will need updating - Fix systemEndpointsReducer (previously was not run) - Fix a cf actions that were using entityFactory
  Fix three quota issues (#3782)
  Bump version and add changelog for 2.5 (#3765)
  Fix SSO tests
  Don't load demo plugin
  Remove demo plugin
  Don't send registration info in query string
  Don't send username/password in the URL
  Fix bug where setup is not saved and fix /uaa after setup
  Add apache2 utils to nginx package
richard-cox pushed a commit that referenced this issue Sep 2, 2019
@KlapTrap
Merge branch 'v3-master' into entity-pipeline
331819e 
* v3-master: (42 commits)
  Fix quotas
  Fix post merge
  Temp fix for linting
  Remove some duped reducers - all other cf specific reducers/functions should move out following #3789
  Fix linting
  Fix autoscaler events page
  Fix typo
  Removed comments
  Fix multiple autoscaler issues - fix charts view (including metrics tiem range selector) - ensure error is shown correctly on edit failure - ensure 404 error is not shown after policy creation - bug - Fix autoscaler events table #3783
  Fix metrics - Ensure metrics actions take in endpoint type   - cfMetrics for cf specific actions, downstream metrics will need updating - Fix systemEndpointsReducer (previously was not run) - Fix a cf actions that were using entityFactory
  Fix three quota issues (#3782)
  Bump version and add changelog for 2.5 (#3765)
  Fix SSO tests
  Don't load demo plugin
  Remove demo plugin
  Don't send registration info in query string
  Added fav reducers back
  Don't send username/password in the URL
  Fix typing error
  Add github issue link to features/parts that should move
  ...
@richard-cox richard-cox changed the title Pull out cf specific code from permissions model Make permissions model extension friendly May 27, 2020
@richard-cox richard-cox added this to the 3.3.0 milestone May 27, 2020
@richard-cox richard-cox mentioned this issue May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extensions
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Make permissions model extension friendly cloudfoundry/stratos
1 participant
@richard-cox