User Favourites: Remove deleted applications

[troytop]

Frontend Deployment type

• Cloud Foundry Application (cf push)
• Kubernetes, using a helm chart
• Docker, single container deploying all components
• npm run start
• Other (please specify below)

Expected behaviour

When I delete an application from cf, I expect the box for this application to dissapear from the Favourites list in the Home view.

Actual behaviour

The application disappears from the Application view, but persists on the Home view. When I redeploy the application and click the Favourite star on the newly (re)deployed application, I get a duplicate entry on the Home view. One of them leads to the new application, the other leads to main Applications view.

Context

Possible Implementation

[KlapTrap]

Good spot.

Implementation notes:

Any entity that the user deletes during their session will be marked as deleted in the entity request section of the store. The user favourites sync should notice the deleted flag and remove any orphaned favourites.

If an entity that has been favourited is deleted outside of the session i.e. by someone else, and if the user clicks that favourite then we should show some 404 page or at least some messaging as to why they've been taken to the application wall.

[KlapTrap]

See #3699 for 404 page.