fix and reset service instance count in sfcluster #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jintusebastian
commented
Sep 12, 2023
jintusebastian
commented
- fixed the issue in instance counter controler flow
- fixed the instance count in sfcluster in case of mismatch
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
==========================================
- Coverage 73.07% 72.37% -0.70%
==========================================
Files 48 48
Lines 4639 4641 +2
==========================================
- Hits 3390 3359 -31
- Misses 900 925 +25
- Partials 349 357 +8 |
vinaybheri
approved these changes
Sep 12, 2023
anoopjb
approved these changes
Sep 12, 2023
| // Calculate the expected service instance count for each cluster | ||
| instanceCount := make(map[string]int) | ||
| for more := true; more; more = (sfserviceinstances.Continue != "") { | ||
| err := client.List(ctx, sfserviceinstances, instanceOptions, kubernetes.Limit(constants.ListPaginationLimit), |
There was a problem hiding this comment.
It is nice that we are only reading 100 (constants.ListPaginationLimit) sfserviceinstances at a time 👍 . This should prevent the possibility of an out of memory error in heavy landscapes. I think it will be a good idea to monitor memory usage after releasing this feature.
Here is a guide from Golang garbage collector, https://tip.golang.org/doc/gc-guide#Optimization_guide
jintusebastian
force-pushed
the
fix/sfcluster-serviceinstance-count-mismatch
branch
from
9c5aea8 to
4b08117
Compare
jintusebastian
deleted the
fix/sfcluster-serviceinstance-count-mismatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.