This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
[IOP] : Adding New Metrics controllers to push metrics to prometheus #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vinaybheri
commented
Mar 14, 2023
vinaybheri
commented
- Currently the sfserviceinstance metrics are sent from sfserviceinstancereplicator controller. For better channelization and readability now we have created new controller sfserviceinstancemetrics to push sfserviceinstance metrics to prometheus.
- Similarly till now the sfservicebinding metrics are sent from sfservicebindingreplicator controller. For better channelization and readability now we have created a new controller sfservicebindingmetrics to push sfservicebinding metrics to prometheus.
* service id, plan id, organization guid and space guid * creation and deletion timestamp * sf namespace & etc.
jintusebastian
suggested changes
Jun 8, 2023
There was a problem hiding this comment.
Looks like some commits are unrelated to this PR: 762c359
Please rebase the branch with master
|
@jintusebastian Updated changes with latest master branch changes. |
vinaybheri
force-pushed
the
metrics-controllers
branch
5 times, most recently
from
c46aae7 to
ec665ec
Compare
vinaybheri
force-pushed
the
metrics-controllers
branch
3 times, most recently
from
3046d1a to
fe8c5b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
- Coverage 72.73% 70.79% -1.94%
==========================================
Files 46 47 +1
Lines 4471 4589 +118
==========================================
- Hits 3252 3249 -3
- Misses 879 991 +112
- Partials 340 349 +9 |
vinaybheri
force-pushed
the
metrics-controllers
branch
6 times, most recently
from
8425d93 to
815d198
Compare
vinaybheri
force-pushed
the
metrics-controllers
branch
from
815d198 to
4d18539
Compare
vinaybheri
force-pushed
the
metrics-controllers
branch
from
4d18539 to
b9d7dc6
Compare
anoopjb
reviewed
Jun 20, 2023
...controllers/multiclusterdeploy/sfservicebindingmetrics/sfservicebindingmetrics_controller.go
Outdated
Show resolved
Hide resolved
anoopjb
reviewed
Jun 20, 2023
...ntrollers/multiclusterdeploy/sfserviceinstancemetrics/sfserviceinstancemetrics_controller.go
Outdated
Show resolved
Hide resolved
…metrics/sfserviceinstancemetrics_controller.go Co-authored-by: Anoop Joseph Babu <anoop.joseph.babu@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.