This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
Broker logging enhancements #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent logging authorization header
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/182208760 The labels on this github issue will be updated when the story is started. |
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
==========================================
- Coverage 73.29% 72.93% -0.37%
==========================================
Files 46 46
Lines 4441 4441
==========================================
- Hits 3255 3239 -16
- Misses 851 863 +12
- Partials 335 339 +4 |
Pull Request Test Coverage Report for Build 6136
💛 - Coveralls |
jintusebastian
approved these changes
May 18, 2022
jintusebastian
approved these changes
May 23, 2022
jintusebastian
pushed a commit
to jintusebastian/service-fabrik-broker
that referenced
this pull request
Feb 13, 2023
- Prevent logging authorization header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the HTTPClient, a debug logger logs the options used in the HTTP request. This log statement may expose tokens if the options has authorization header. This change omits the authorization header while logging.