Set 'instance' in the context to be used by dashboard url. #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the plan contains dashboard url, it may refer to the sfserviceinstance for reading the name & cluster id properties. If the instance is not present it throws an exception and the GET call fails.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/181768146 The labels on this github issue will be updated when the story is started. |
jintusebastian
approved these changes
Apr 4, 2022
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/181787065 The labels on this github issue will be updated when the story is started. |
Codecov Report
@@ Coverage Diff @@
## master #1603 +/- ##
==========================================
- Coverage 73.06% 72.95% -0.12%
==========================================
Files 45 46 +1
Lines 4348 4441 +93
==========================================
+ Hits 3177 3240 +63
- Misses 836 860 +24
- Partials 335 341 +6 |
anoopjb
approved these changes
Apr 5, 2022
jintusebastian
pushed a commit
to jintusebastian/service-fabrik-broker
that referenced
this pull request
May 17, 2022
If the plan contains dashboard url, it may refer to the sfserviceinstance for reading the name & cluster id properties. If the instance is not present it throws an exception and the GET call fails.
jintusebastian
pushed a commit
to jintusebastian/service-fabrik-broker
that referenced
this pull request
Feb 13, 2023
If the plan contains dashboard url, it may refer to the sfserviceinstance for reading the name & cluster id properties. If the instance is not present it throws an exception and the GET call fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plan contains dashboard url, it may refer to the sfserviceinstance for reading the name & cluster id properties. If the instance is not present it throws an exception and the GET call fails.
Fix for: https://jtrack.wdf.sap.corp/browse/NGPBUG-181387