Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGPBUG-165701 #1455

Merged
merged 1 commit into from
Oct 25, 2021
Merged

NGPBUG-165701 #1455

merged 1 commit into from
Oct 25, 2021

Conversation

jintusebastian
Copy link
Contributor

ServiceInventoryId displayed with wrong key name in cloud logging broker metadata

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/180043897

The labels on this github issue will be updated when the story is started.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1455 (855027e) into master (b5a2472) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
+ Coverage   72.92%   72.94%   +0.02%     
==========================================
  Files          44       44              
  Lines        4218     4218              
==========================================
+ Hits         3076     3077       +1     
  Misses        813      813              
+ Partials      329      328       -1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5659

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 88.644%
Files with Coverage Reduction New Missed Lines %
broker/data-access-layer/cf/src/TokenIssuer.js 1 98.55%
Totals Coverage Status
Change from base Build 5639: -0.007%
Covered Lines: 9717
Relevant Lines: 10580
💛 - Coveralls

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri

This comment has been minimized.

Sign in to view
5 similar comments
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri

This comment has been minimized.

Sign in to view
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@vinaybheri

This comment has been minimized.

Sign in to view
1 similar comment
@vinaybheri

This comment has been minimized.

Sign in to view
@vinaybheri

This comment has been minimized.

Sign in to view
1 similar comment
@vinaybheri

This comment has been minimized.

Sign in to view
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri

This comment has been minimized.

Sign in to view
1 similar comment
@vinaybheri

This comment has been minimized.

Sign in to view
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

1 similar comment
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n failed.

@jintusebastian jintusebastian merged commit 0a34ac7 into cloudfoundry:master Oct 25, 2021
@jintusebastian jintusebastian deleted the NGPBUG-165701-serviceInventoryId-displayed-with-wrong-key-name-in-metadata branch October 25, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saud89 saud89 saud89 approved these changes

@anoopjb anoopjb Awaiting requested review from anoopjb

@Pooja-08 Pooja-08 Awaiting requested review from Pooja-08

@vinaybheri vinaybheri Awaiting requested review from vinaybheri

@visargsoneji visargsoneji Awaiting requested review from visargsoneji

@swati1102 swati1102 Awaiting requested review from swati1102

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jintusebastian @cf-gitbot @coveralls @vinaybheri @saud89